Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Prettier doc #1212

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Edit Prettier doc #1212

merged 1 commit into from
Apr 1, 2019

Conversation

ruthemmanuelle
Copy link
Contributor

@ruthemmanuelle ruthemmanuelle commented Mar 29, 2019

What does this PR do?

  • Edits @ntotten 's new setup doc for Prettier.
  • Moves the Prettier doc to the Getting Started section, since it's about setting up Prettier more than about using it.

What issues does this PR fix or reference?

#1208, @W-6003543@

@ruthemmanuelle ruthemmanuelle requested a review from ntotten March 29, 2019 22:56
@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #1212 into prettier_doc will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           prettier_doc   #1212      +/-   ##
===============================================
+ Coverage         70.88%     71%   +0.12%     
===============================================
  Files               196     196              
  Lines              7397    7397              
  Branches            781     781              
===============================================
+ Hits               5243    5252       +9     
+ Misses             1998    1989       -9     
  Partials            156     156
Impacted Files Coverage Δ
...x-replay-debugger/test/integration/goldFileUtil.ts 97.72% <0%> (+20.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b4637f...dd09460. Read the comment docs.

Copy link
Contributor

@lcampos lcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcampos lcampos merged commit 8c2447d into prettier_doc Apr 1, 2019
@lcampos lcampos deleted the ruth/prettier-doc branch April 1, 2019 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants