Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit code coverage messages #1159

Merged
merged 2 commits into from
Mar 18, 2019
Merged

Edit code coverage messages #1159

merged 2 commits into from
Mar 18, 2019

Conversation

ruthemmanuelle
Copy link
Contributor

What does this PR do?

@lcampos - I made a couple more changes to your messages.

What issues does this PR fix or reference?

#1145

@ruthemmanuelle ruthemmanuelle requested a review from lcampos March 18, 2019 16:45
@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #1159 into develop will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1159      +/-   ##
===========================================
- Coverage    72.71%   72.67%   -0.05%     
===========================================
  Files          193      193              
  Lines         7221     7221              
  Branches       746      746              
===========================================
- Hits          5251     5248       -3     
- Misses        1813     1814       +1     
- Partials       157      159       +2
Impacted Files Coverage Δ
...edx-vscode-core/src/telemetry/telemetryReporter.ts 50.7% <0%> (-2.82%) ⬇️
...forcedx-vscode-core/src/channels/channelService.ts 83.33% <0%> (-2.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 504d1d7...9d247b8. Read the comment docs.

@lcampos lcampos merged commit dda8d99 into develop Mar 18, 2019
@lcampos lcampos deleted the ruth/code-cov-messages branch March 18, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants