Apex LSP perf fix to updateTypeInfos only on latest doc version #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praksb
requested review from
AnanyaJha,
brpowell,
allileong,
JimSuplizio,
lcampos and
sfsholden
Codecov Report
@@ Coverage Diff @@
## develop #1086 +/- ##
========================================
Coverage 60.87% 60.87%
========================================
Files 75 75
Lines 3387 3387
Branches 599 599
========================================
Hits 2062 2062
Misses 1218 1218
Partials 107 107Continue to review full report at Codecov.
|
lcampos
approved these changes
Feb 21, 2019
praksb
added a commit
that referenced
this pull request
Feb 21, 2019
praksb
added a commit
that referenced
this pull request
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a performance issue in Apex LSP caused by document change requests queuing up and LSP trying to process all the document change requests.
What issues does this PR fix or reference?
@W-5850717@
#1047
This fixes some of the Java high CPU usage issues that were reported by a few customers.