Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow increased query fetch limits #500

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Feb 2, 2024

Updated the code to fetch 10,000 records max by default. To set it higher than that use the SF_ORG_MAX_QUERY_LIMIT env var.

@W-13047283@
forcedotcom/cli#2073

src/package1/package1Version.ts Outdated Show resolved Hide resolved
src/package/packageVersionList.ts Outdated Show resolved Hide resolved
src/package/packageVersionList.ts Outdated Show resolved Hide resolved
src/package/package.ts Outdated Show resolved Hide resolved
@mshanemc
Copy link
Contributor

mshanemc commented Feb 5, 2024

QA:

ran sf package version list against na40 hub with linked library.

✅ Saw 10k records, got a warning Warning: The query result is missing 1064 records due to a 10000 record limit. Increase the number of records returned by setting the config value "maxQueryLimit" or the environment variable "SF_ORG_MAX_QUERY_LIMIT" to 11064 or greater than 10000.
✅ error goes to stderr in both human and json

@mshanemc mshanemc merged commit 665dc19 into main Feb 5, 2024
11 checks passed
@mshanemc mshanemc deleted the sh/increase-list-fetch-limit branch February 5, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants