Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set additional fields to PackageVersionCreateRequestResult #466

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

Rocko1204
Copy link
Contributor

@Rocko1204 Rocko1204 commented Dec 14, 2023

Add the Package2.Name and Coverage Check to the PackageVersionCreateRequestResult Output.

Advantage:

The package name is in the lifecycle hooks and so we can use this info to make checks in the project json file.
I'm currently converting our build job (https://github.com/dxatscale/sfpowerscripts/tree/main) to lifecycle hooks and then we would save ourselves having to search for the package name. The coverage check is in the output as well , so we need no additional checks for result <> 75%.

@W-14811085@

Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): R6736 <r***@e***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

@Rocko1204 Rocko1204 force-pushed the feat/package-name-version-create branch from 82f0653 to 62f3b10 Compare December 14, 2023 14:03
@Rocko1204 Rocko1204 changed the title feat: set package2name in lifecycle hook results feat: set additional fields to PackageVersionCreateRequestResult Dec 14, 2023
@shetzel shetzel merged commit c28e75f into forcedotcom:main Jan 12, 2024
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants