Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
plugin library passes around the
PackageInstallOptions
. If you pass any options, it eventually gets to herepackaging/src/package/packageInstall.ts
Line 199 in b7c470d
where an undefined
frequency
will become0
. It looks like the intent was to have a 5 sec default. So now both defaults are applied when options are sent BUT freq or timeout aren't included in those options.What issues does this PR fix or reference?
forcedotcom/cli#2319
@W-13797305@