Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use default polling freq #355

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Conversation

mshanemc
Copy link
Contributor

the freq is set in the plugin now, so this PR isn't required to close the gh issue. This change is to prevent other library consumers from hitting the same bug the plugin was.

What does this PR do?

plugin library passes around the PackageInstallOptions. If you pass any options, it eventually gets to here

const { pollingFrequency, pollingTimeout } = options;

where an undefined frequency will become 0. It looks like the intent was to have a 5 sec default. So now both defaults are applied when options are sent BUT freq or timeout aren't included in those options.

What issues does this PR fix or reference?

forcedotcom/cli#2319
@W-13797305@

@WillieRuemmele WillieRuemmele merged commit d4c2458 into main Jul 24, 2023
@WillieRuemmele WillieRuemmele deleted the sm/default-polling-options branch July 24, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants