Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when resolving dependencies the branch attribute should be preferred #310

Merged
merged 2 commits into from
Jun 6, 2023
Merged

fix: when resolving dependencies the branch attribute should be preferred #310

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e94e753
fix: when resolving dependencies the branch attribute should be prefe…
David-Polehonski May 31, 2023
c6f2d61
feat: added unit test to support dependency branch verification
David-Polehonski Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/package/packageVersionCreate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ export class PackageVersionCreate {
const buildNumber = versionNumber.build;

// use the dependency.branch if present otherwise use the branch of the version being created
const branch = dependency.branch === '' ? dependency.branch : this.options.branch;
const branch = dependency.branch === '' ? this.options.branch : dependency.branch;
const branchString = !branch || branch === '' ? 'null' : `'${branch}'`;

// resolve a build number keyword to an actual number, if needed
Expand Down