fix: clone sfdx-project.json deps to avoid writing back to the file #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arafesthain
approved these changes
Nov 2, 2022
peternhale
approved these changes
Nov 7, 2022
src/package/packageVersionCreate.ts
Outdated
| @@ -368,7 +368,8 @@ export class PackageVersionCreate { | |||
|
|
|||
| // All dependencies for the packaging dir should be resolved to an 04t id to be passed to the server. | |||
| // (see _retrieveSubscriberPackageVersionId for details) | |||
| const dependencies = packageDescriptorJson.dependencies; | |||
| // can be changed to structuredClone once node18 is the minimum version | |||
| const dependencies = JSON.parse(JSON.stringify(packageDescriptorJson.dependencies)) as PackageDirDependency[]; | |||
There was a problem hiding this comment.
@WillieRuemmele could use kit#cloneJson
shetzel
approved these changes
Nov 7, 2022
peternhale
approved these changes
Nov 8, 2022
peternhale
approved these changes
Nov 8, 2022
WillieRuemmele
changed the title
peternhale
approved these changes
Nov 9, 2022
tshopshireSalesforce
pushed a commit
to tshopshireSalesforce/packaging
that referenced
this pull request
Jan 24, 2023
…orcedotcom#117) * fix: clonse sfdx-project.json deps to avoid writing back to the file * chore: node 16 way of copying * chore: change to cloneJson from kit * chore: guard against no deps when cloning * fix: clone entry to include unpackagedMetadata entry, add UT * chore: clone at top level only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@W-11935313@
forcedotcom/cli#1764
fixes dependencies being written as
subscriberPackageVersionId: XXXforce-app(main)pkg/classes/newClass.cls(dep)deppackage versionto your
mainpackage entry5. create a new package version of
main@W-11927980@
forcedotcom/cli#1743
DreamhouseLWCin the package aliases sectionbetacommands