Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Bug>(Commerce:Extension) Fix extension-unmap-error #306

Merged

Conversation

cw112233
Copy link
Contributor

@cw112233 cw112233 commented Feb 27, 2024

What does this PR do?

extension-unmap-error

What issues does this PR fix or reference?

#, @@

@W-15031437@

Functionality Before

<insert gif and/or summary>

Functionality After

<insert gif and/or summary>

How to Test/Testing Effort

<insert gif and/or summary>

Register: ./bin/run commerce:extension:register --targetusername <targetusername> --apex-class-name PricingDemoService --extension-point-name Commerce_Domain_Pricing_Service --registered-extension-name PricingDemoService

Map: ./bin/run commerce:extension:map --registered-extension-name PricingDemoService --store-id <storeId> -u <targetusername>

Unmap: ./bin/run commerce:extension:unmap --registered-extension-name PricingDemoService -u <targetusername> --store-id <storeId>

Copy link

@Yuanchen-S Yuanchen-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Selecting Id field is much cleaner and easier to read. Noticed CI failed at the set up stage. Do we need a new ticket to address that?

Copy link
Contributor

@tarcang tarcang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I know why the e2e test fails, it is because Chris is creating the PR from a forked repository which doesn't have the workflow secrets.

@cw112233 cw112233 merged commit 9cbaa09 into forcedotcom:develop Feb 27, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants