@W-14700593 | Remove commit hook logic that bumps patch version after every commit #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cw112233
reviewed
Jan 2, 2024
| @@ -60,7 +60,7 @@ $ npm install -g @salesforce/commerce | |||
| $ sfdx COMMAND | |||
| running command... | |||
| $ sfdx (-v|--version|version) | |||
| @salesforce/commerce/250.0.0 darwin-x64 node-v18.16.1 | |||
| @salesforce/commerce/250.1.0 darwin-x64 node-v18.16.1 | |||
There was a problem hiding this comment.
Any reason to bump this version in read me?
There was a problem hiding this comment.
It was supposed to bump earlier during release, yarn version didn't run in the pipeline
cw112233
approved these changes
Jan 2, 2024
Yuanchen-S
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes updating the patch version every time a commit happens. In the past, this allowed for confusions in release versioning.
What issues does this PR fix or reference?
@W-14700593@
Note: I have investigated how to get rid of the minor version bump after pushing to main but I have realized that would require a bigger change in onPushToMain workflow than I expected. In the inherited workflow, the input option for "skip-version-file" for the https://github.com/TriPSs/conventional-changelog-action/commits?author=TriPSs that is used in the workflow is not exposed. This means instead of inheriting from the oclif github workflows, we had to copy paste the whole file just to add the "skip-version-file: true" tag. Seemed to much change since it would add a lot of maintenance overhead.