Fix compatibility with Windows #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ond condition cause the test to be flaky.
Yuanchen-S
reviewed
Dec 4, 2023
scripts/prepare.mjs
Outdated
|
|
||
| switch (os.platform()) { | ||
| case 'win32': | ||
| command = 'del -f .oclif.manifest.json && yarn run prepack && husky install'; |
There was a problem hiding this comment.
Shall we use del /f in windows? force delete in windows
There was a problem hiding this comment.
We can! I have ran this command and it worked, but I would rather use the official version of the flag.
Yuanchen-S
approved these changes
Dec 4, 2023
o-olaosebikan
approved these changes
Dec 4, 2023
kalagarraj
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issues with Windows environments
What issues does this PR fix or reference?
@W-13312965@
Functionality Before
Store creation would fail in Windows Powershell
Functionality After
Now the store is mostly created fine. I have created this issue forcedotcom/cli#2581 to help resolve the deployment issue in windows. I will follow this issue closely.
How to Test/Testing Effort
Created stores in windows environment, yarn test