force:source:push doesn't fail on component failures

[noerremark]

Steps To Reproduce:

1. Change a component to something obviously invalid
2. Run ($? is the Return Code)

force:source:push
echo $?

3. Observe that the code returned is 0, which indicates that no failure happened

Expected result

Since the push actually failed, it should have returned something else than 0.

Actual result

Pushing v53.0 metadata to [email protected] using the v57.0 SOAP API
DEPLOY PROGRESS | ████████████████████████████████████████ | 1/1 Components
Updating source tracking... done

=== Pushed Source

 STATE   FULL NAME  TYPE      PROJECT PATH                                           
 ─────── ────────── ───────── ────────────────────────────────────────────────────── 
 Changed c_UnitTest ApexClass force-app/main/default/classes/c_UnitTest.cls          
 Changed c_UnitTest ApexClass force-app/main/default/classes/c_UnitTest.cls-meta.xml 

=== Component Failures [1]

 Type  Name                            Problem                 
 ───── ─────────────────────────────── ─────────────────────── 
 Error classes/c_UnitTest.cls-meta.xml Invalid api version:0.0 

0

System Information

sfdx-cli/7.192.2 darwin-x64 node-v18.14.1

[github-actions]

Thank you for filing this issue. We appreciate your feedback and will review the issue as soon as possible. Remember, however, that GitHub isn't a mechanism for receiving support under any agreement or SLA. If you require immediate assistance, contact Salesforce Customer Support.

[iowillhoit]

Interesting, I am not seeing that.

• When you run this with --json does it give you an exitCode and status of 1?
• Could you send the full output of sfdx version --verbose

[iowillhoit]

Ok i was able to reproduce this. In my example above there were only failures, which gave an exitcode of 1 as expected. When you have a push that has successes and failures, it looks like you should get an exit code 68 to show partial success.

Source: https://github.com/salesforcecli/plugin-source/blob/main/src/commands/force/source/push.ts#L200-L215

I will get a ticket created and confirm with the team. Thanks @noerremark!

[git2gus]

This issue has been linked to a new work item: W-12727451

[iowillhoit]

This is working as expected in the new project deploy start command, please use that command instead. Note that we did just merge in a fix to properly print component failures to stdout. That will be in latest-rc next week.