-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin got broken after CLI update #1664
Comments
Thank you for filing this issue. We appreciate your feedback and will review the issue as soon as possible. Remember, however, that GitHub isn't a mechanism for receiving support under any agreement or SLA. If you require immediate assistance, contact Salesforce Customer Support. |
@patrykacc I'm unable to reproduce the issue on Are you able to provide steps to reproduce? |
I am seeing a similar issue with wry after updating to 7.163.0 from version 7.156.1, and a teammate is experiencing the same issue. The plugin still links properly though, just cannot be found when run. |
Having the same problem. The issue seems to be with Update: |
Same issue here (with another custom plugin). Downgrading to |
I've tried the following but have not been able to reproduce it:
After updating I'm still able to see all the
So a couple of follow up questions:
Thanks! |
@mdonnalley In my experience it only happens to locally linked plugins, not installed ones. So:
You should not be getting any commands, although the namespace may be listed if the |
@hansds I'm still unable to replicate it by following those steps. Are you able to get your plugin working again by uninstalling and reinstalling it? |
@mdonnalley I'll stress again that we're not installing, but linking. Installed plugins do not show the behaviour. Unlinking and linking does not however fix the issue, only downgrading did I'm afraid... |
@hansds I understand. I followed your instructions to link the plugin and was still able to access all the Can you provide the output from |
Same on our side, in all environments, including all CI servers.
I'm also linking, not installing. We had to downgrade to 7.162.0. As an example, I use 16-alpine3.15 node docker image. |
We are also experiencing the same problem with our plugins when running it in CI. The command is no longer recognized although the plugin was successfully linked before running it. |
I had to downgrade the CLI to keep the plugin working but here is my output with
|
The below reflects @uwe-voellger's environments with the latest CLI. We are currently working by downgrading to 7.162.0.
|
I reproduced this issue in both pre-7.163.0 versions and post-7.163.0 versions if I do not compile the plugin after linking it. If, however, I compile the plugin I see the commands appear. But, I see this behavior in both newer and older versions so I'm not convinced that that's the issue others are running into. Can someone who's experiencing this try compiling the plugin to see if that resolves it? |
@mdonnalley can you provide steps to compile? That hasn't been part of our workflow and I can't find much documentation on that process but I'd be willing to try |
@slaght it should be a script defined in your plugin's package.json. For example, |
@mdonnalley tried linking the plugin both before and after installing it and did not resolve the issue. This is also on the new 7.164.2 release |
We faced the same problem with the same release versions. However based on the suggestion to "compile" we managed to solve the problem. We have a prepack command but that did not change anything. Instead running build
(Run with "npm run build") |
I am also seeing the same issue since last few releases of sfdx and it was definitely not present before. Another way of reproducing this issue is to generate plugin with sfdx and link it:
If I run npm run build in plugin-test directory I can get it to work. However, in the past it used to work properly without this additional step. You can see in the docs (https://developer.salesforce.com/docs/atlas.en-us.sfdx_cli_plugins.meta/sfdx_cli_plugins/cli_plugins_generate_scaffold.htm) that it was never required to compile the plugin as I believe sfdx should do it when plugin is linked. |
This issue has been linked to a new work item: W-11731121 |
We are dealing with the same issue. I reproduced steps which filiprafalowicz wrote with 7.168.0, 7.163.0, 7.162.0, 7.160.0. It works perfectly fine with lower or equal version than 7.162.0. What I noticed more, that if I try to run plugin by path, it returns something.
What worth mention "bin/run hello:org -u MyOrg" returns error. When I execute the same command with 7.162.0 version, the output is correct
I hope it will be useful somehow |
This is effecting us as well. Grateful to the community posting here. Feels good to know that we're not alone. |
Same thing for us. Any timelines on having this fixed/workaround being provided which doesnt stop us from upgrading. There is a couple of things which are not working in new SF release due to not being able to upgrade the plugin. |
Been experiencing this, too. Last version works is 7.162.0. |
I also need resolution on this. Latest version I can use is 7.162.0. |
Is there any update on status of work item W-11731121? My team and I have had to pin our version to 7.162.0, we would really like to keep up to date so we can get access to new features and bugfixes but we are blocked from doing so until this issue is resolved. |
Yes I need an update as well. |
Is there any update on this issue? We are still using 7.162.0 version as the others have mentioned above |
This issue is still on our backlog, but has yet to be prioritized. |
@peternhale How can we get this issue prioritized? We are unable to update beyond version 7.162.0 because of this. |
If you're linking a local plugin, it sounds like "build/compile it first" is a good workaround. Other options would be installing the plugin the normal way (ex What's the situation where you can't use either of those options? Linked plugins are meant for the plugin developer to be able to test their changes locally before going through the npm publish process, where they probably re-build/compile stuff regularly). |
@mshanemc The "build/compile it first" used be come for free before, or so it seemed that way. In our particular case, we don't publish our sfdx plugin to any kind of npm registry, we have it as a sub directory in our source repository that houses our force-app. We link it once after cloning the source repository and then the plugin would just work, even if we changed branches and those branches contained new commands/topics in the plugin. So it's always in a "development" state and this has worked great for us for many years up to v7.162.0 but after that this is no longer the case. It's been a while since I read the entire documentation for the plugin development but the documentation page Scaffold a Salesforce CLI Plug-In does not mention build/compile. If it is a requirement to build/compile before running commands then maybe the documentation should be updated to explain that and also show the necessary commands to build/compile? |
It's definitely a bug and not an intentional change. 😄 There's a lot of comments saying it's blocking people from using newer CLIs, but to prioritize this vs other work it would be helpful to understanding why they're blocked when there's a few pretty good workarounds. |
Where are the workarounds for us to see if that will work? |
A happy side effect from workaround #2 is that it'll save you some CI time |
@mshanemc this isnt really a workaround for many enterprises. If they need to keep the dev private and dont have a private registry available then it wont work last i checked. This means for those clients we are stuck with 162. Why would we upgrade? well, while its not urgent, many times it has newer support for newer features which we sometimes need to upgrade to (release updates for example) |
@DougMidgley what prevents you from adding a build/compile step before |
Summary
Result of executing "sfdx texei" command before executing "sfdx:update" command
Result of executing "sfdx texei" command before executing "sfdx:update" command
Comment: as you see above, TOPICS section is missing after I updated my CLI, and that makes also that exuction of dependencies install command for plugin TEXEI fails, which breaks my CD:
System Information
sfdx-cli: Updating CLI from 7.94.3-a4e7c7955b to 7.163.0-ea5a9c6... done
The text was updated successfully, but these errors were encountered: