Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nav bar color for user detail #3818

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

bbirman
Copy link
Member

@bbirman bbirman commented Jan 28, 2025

before & after

Screenshot 2025-01-27 at 3 40 27 PM Screenshot 2025-01-27 at 3 40 27 PM

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.98%. Comparing base (34ce7f8) to head (25ebb8b).
Report is 20 commits behind head on dev.

Files with missing lines Patch % Lines
...ontrollers/SFDefaultUserManagementViewController.m 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3818      +/-   ##
==========================================
- Coverage   62.00%   61.98%   -0.03%     
==========================================
  Files         233      233              
  Lines       21654    21749      +95     
==========================================
+ Hits        13427    13481      +54     
- Misses       8227     8268      +41     
Components Coverage Δ
Analytics 81.88% <ø> (-1.26%) ⬇️
Common 68.87% <ø> (+0.08%) ⬆️
Core 50.67% <63.15%> (+0.03%) ⬆️
SmartStore 73.70% <ø> (+<0.01%) ⬆️
MobileSync 87.58% <ø> (ø)
Files with missing lines Coverage Δ
...ontrollers/SFDefaultUserManagementViewController.m 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

@Crebs
Copy link
Contributor

Crebs commented Jan 28, 2025

I noticed these test-ios runs are failing on my PR too. Is that related to any recent changes that might have gottne merged while my User permission stuff was failing?

@bbirman
Copy link
Member Author

bbirman commented Jan 28, 2025

I noticed these test-ios runs are failing on my PR too. Is that related to any recent changes that might have gottne merged while my User permission stuff was failing?

If it's these four five, I don't think so, they've been flapping for a bit. That's another thing we should look at before releasing if you want to work on that

testPublicApiCalls
testCredentialsCopying
testUserAccountEncoding
testLockScreenTriggers
testMetricsAction (edited to add)

@bbirman bbirman merged commit 6f49ba2 into forcedotcom:dev Jan 28, 2025
7 of 8 checks passed
@bbirman bbirman deleted the user-detail branch January 28, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants