Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove userLogout AILTN event #3817

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Remove userLogout AILTN event #3817

merged 3 commits into from
Jan 28, 2025

Conversation

Crebs
Copy link
Contributor

@Crebs Crebs commented Jan 27, 2025

No description provided.

Copy link

github-actions bot commented Jan 27, 2025

1 Warning
⚠️ Static Analysis found an issue with one or more files you modified. Please fix the issue(s).

Clang Static Analysis Issues

File Type Category Description Line Col
SFRestAPI Nullability Memory error nil assigned to a pointer which is expected to have non-null value 98 5
SFRestAPI Nullability Memory error nil passed to a callee that requires a non-null 2nd parameter 483 9

Generated by 🚫 Danger

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.01%. Comparing base (34ce7f8) to head (4a90a3b).
Report is 20 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff            @@
##              dev    #3817    +/-   ##
========================================
  Coverage   62.00%   62.01%            
========================================
  Files         233      233            
  Lines       21654    21878   +224     
========================================
+ Hits        13427    13568   +141     
- Misses       8227     8310    +83     
Components Coverage Δ
Analytics 81.88% <ø> (-1.26%) ⬇️
Common 68.87% <ø> (+0.08%) ⬆️
Core 50.83% <63.63%> (+0.19%) ⬆️
SmartStore 73.70% <ø> (+<0.01%) ⬆️
MobileSync 87.58% <ø> (ø)
Files with missing lines Coverage Δ
...Core/SalesforceSDKCore/Classes/RestAPI/SFRestAPI.m 82.46% <ø> (-5.99%) ⬇️

... and 8 files with indirect coverage changes

@Crebs Crebs requested review from bbirman and wmathurin January 27, 2025 20:33
bbirman
bbirman previously approved these changes Jan 28, 2025
@bbirman bbirman dismissed their stale review January 28, 2025 19:03

Noticed attributes question

@Crebs Crebs merged commit 164ad1a into forcedotcom:dev Jan 28, 2025
7 of 8 checks passed
@Crebs Crebs deleted the @W-14212091 branch January 28, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants