This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Drop support for building prefixed variants of tests #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefixed variants are now done via custom IDL and CSS. update-bcd.js isn't able to map those back to the prefixed entries in BCD, then also isn't able to do that for the mechanism now deleted. This doesn't change the build tests.json at all because it was unused.
This was actually wrong, there is some support in update-bcd.js for prefixed entries. I don't know if it works though, since the results haven't had any prefixes in them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefixed variants are now done via custom IDL and CSS. update-bcd.js
isn't able to map those back to the prefixed entries in BCD, then also
isn't able to do that for the mechanism now deleted.
This doesn't change the build tests.json at all because it was unused.