This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Simplify results export into form submission and server-side logic #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensuring that the export works on old browsrs and automating it using Selenium is more complicated when there's more happening on the client side. Collapse everything into a POST /export endpoint, getting rid of /api/results/export/*. This new code is not tested.
foolip
changed the title
foolip
changed the title
foolip
added a commit
that referenced
this pull request
Feb 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensuring that the export works on old browsrs and automating it using
Selenium is more complicated when there's more happening on the client
side. Collapse everything into a POST /export endpoint, getting rid of
/api/results/export/*.
This new code is not tested.