Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Message Formatting with Actiontext Trix Editor #1013

Merged
merged 4 commits into from
Aug 4, 2023

Conversation

yksflip
Copy link
Member

@yksflip yksflip commented Jun 21, 2023

This introduces to possibility to send formatted messages and attachments with the messages plugin.

  • fix render attachment to actually display a link to attachement
  • scheduled cleanup for attachments
  • max file size
    *[ ] test email reply with attachment, is it shown in foodsoft then?
    tried around a bit but still not sure what's going on there, I'd guess the message data will just be shown as a plaintext.
    I think if this is a use case we can have a look at some other point ...

@yksflip yksflip added this to the 4.8 milestone Jun 21, 2023
@yksflip
Copy link
Member Author

yksflip commented Jun 21, 2023

two questions that are open to me:

  1. Any ideas for a better way in the message .html template than using this extra translations fields?
  2. At the moment the db migration, javascript etc. is done globally, even though the message is a plugin. Should I try to move everything to the messages plugin or can it stay there, as Actiontext might be useful in other places e.g. the Wiki?

@yksflip
Copy link
Member Author

yksflip commented Jul 12, 2023

@lentschi could you have another look at this? :) It' the first rake task I ever wrote, but I think it works as intended.

For the rake task I'd leave a note addressing the new config field in the Release Notes ...

Copy link
Member

@decentral1se decentral1se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick pass on this, LGTM! Thanks for working on it, definitely nice feature to have.

Copy link
Member

@paroga paroga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know what you preferred way of working is, but if
a) you want to squash you changes during merge, the PR contains IMHO too much unrelated changes (one commit should change only as little as possible. e.g. (1) just add the trix editor, (2) adopt messaging to use trix, (3) add prune_old_attachments)
b) you want to merge it with the whole commit history, the PR contains too much useless commits like typo fixes.

since developers read code much more often than they write it, creating a clean git history should have some importance. (especially if nobody writes any kind of code documentation ;-))

app/javascript/application.js Outdated Show resolved Hide resolved
app/views/active_storage/blobs/_blob.html.haml Outdated Show resolved Hide resolved
plugins/messages/app/helpers/messages_helper.rb Outdated Show resolved Hide resolved
@yksflip
Copy link
Member Author

yksflip commented Jul 22, 2023

thanks for your review paroga!
You're right regarding the commit history. I was sloppy here and there, I'll split it into more meaningful commits and try to keep that in mind for future PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants