Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_base_has_width: use correct param #4983

Merged
merged 2 commits into from
Jan 30, 2025
Merged

check_base_has_width: use correct param #4983

merged 2 commits into from
Jan 30, 2025

Conversation

m4rc1e
Copy link
Collaborator

@m4rc1e m4rc1e commented Jan 29, 2025

Description

CI is failing for Merriweather, google/fonts#7886 (comment):

ERROR Check base characters have non-zero advance width. [base_has_width](https://fontbakery.readthedocs.io/en/stable/fontbakery/checks/universal.html#base-has-width)
💥 ERROR
Failed with AttributeError: 'CheckRunContext' object has no attribute 'get'

The check is currently trying to pass a context variable into a bullet list, when it actually needs a config variable.

Checklist

  • update CHANGELOG.md
  • wait for the tests to pass
  • request a review

@m4rc1e m4rc1e requested a review from felipesanches January 29, 2025 20:51
@felipesanches felipesanches added this to the 0.13.2 milestone Jan 30, 2025
@felipesanches felipesanches merged commit f84ac84 into main Jan 30, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants