Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[italic_angle] Doesn't actually check that post.italicAngle is as calculated #4908

Open
simoncozens opened this issue Nov 18, 2024 · 0 comments

Comments

@simoncozens
Copy link
Collaborator

I'm not sure what this check is claiming to do; here's what the comments say:

# Checking that italicAngle matches the calculated value
# We allow a 0.1° tolerance

But it does not! It only checks that the sign of the italic angle in the post table matches the sign of the calculated value:

if calculated_italic_angle < 0.1 and value > 0:

if calculated_italic_angle > 0.1 and value < 0:

Maybe that's all the check should do, I don't know. At the same time, if we calculated the italic angle as 15° and the font declares it as 5°, that feels like something the user might want to know, especially since we went to all the trouble to work it out.

@felipesanches felipesanches self-assigned this Nov 18, 2024
@felipesanches felipesanches added this to the 0.13.0 milestone Nov 18, 2024
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 22, 2024
@felipesanches felipesanches modified the milestones: 0.13.0, 0.13.1 Dec 22, 2024
@felipesanches felipesanches removed this from the 0.13.1 milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants