Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[com.google.fonts/check/varfont/family_axis_ranges] doesn't SKIP fonts without fvar #4554

Closed
bobh0303 opened this issue Feb 26, 2024 · 0 comments · Fixed by #4556
Closed

[com.google.fonts/check/varfont/family_axis_ranges] doesn't SKIP fonts without fvar #4554

bobh0303 opened this issue Feb 26, 2024 · 0 comments · Fixed by #4556
Labels
Check improvement proposal

Comments

@bobh0303
Copy link
Contributor

(NOTE: Please include the check-id in the issue's title.)

Observed behaviour

Static fonts that do not contain fvar table result in PASS

Expected behaviour

Static fonts that do not contain fvar table result in SKIP

Resources and steps needed to reproduce

Currently running fontbakery 0.11.1

Example:

❯ fontbakery check-universal --succinct -c family_axis_ranges data/test/cabin/*.ttf
Start ... running 1 individual check executions.

 ERROR: 0 FATAL: 0 FAIL: 0 WARN: 0 INFO: 0 SKIP: 0 PASS: 1
@simoncozens simoncozens mentioned this issue Feb 28, 2024
Merged
3 tasks
felipesanches pushed a commit that referenced this issue Feb 28, 2024
@simoncozens
SKIP varfont/family_axis_ranges when no fvar
c0fd534 
Using "VFs" condition.

com.google.fonts/check/varfont/family_axis_ranges
on the OpenType profile.

(issue #4554)
felipesanches added a commit that referenced this issue Apr 12, 2024
@felipesanches
Promotion of previously experimental checks
2211e6d 
After being marked as **experimental** for 9 weeks since the v0.11.1 release, these checks are now made effective.
For more details, see their previous entries on the changelog.

Made effective on the Open Type profile
  - * **com.typenetwork/check/varfont/ital_range** (PR #4402)
  - * **com.google.fonts/check/varfont/family_axis_ranges** (issue #4554)

Made effective on the Universal profile
  - * **com.google.fonts/check/tabular_kerning** (issue #4440)
  - * **com.google.fonts/check/case_mapping** (issue #3230)
felipesanches added a commit that referenced this issue Apr 12, 2024
@felipesanches
Promotion of previously experimental checks
3a52b51 
After being marked as **experimental** for 9 weeks since the v0.11.1 release, these checks are now made effective.
For more details, see their previous entries on the changelog.

Made effective on the Open Type profile
  - * **com.typenetwork/check/varfont/ital_range** (PR #4402)
  - * **com.google.fonts/check/varfont/family_axis_ranges** (issue #4554)

Made effective on the Universal profile
  - * **com.google.fonts/check/tabular_kerning** (issue #4440)
  - * **com.google.fonts/check/case_mapping** (issue #3230)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Check improvement proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SKIP varfont/family_axis_ranges when no fvar fonttools/fontbakery
1 participant
@bobh0303