Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com.google.fonts/check/kerning_for_non_ligated_sequences incorrectly reports missing kerning for hyphen+greater / less+hyphen #2954

Open
marcologous opened this issue Jul 2, 2020 · 3 comments
Assignees

Comments

@marcologous
Copy link

Screen Shot 2020-07-02 at 11 09 58 PM

Screen Shot 2020-07-02 at 11 10 31 PM

Screen Shot 2020-07-02 at 11 09 44 PM

@felipesanches felipesanches self-assigned this Jul 2, 2020
@felipesanches felipesanches added this to the 0.8.upcoming milestone Jul 2, 2020
@marcologous
Copy link
Author

https://travis-ci.org/github/marcologous/hanken-grotesk/builds/704431313#L1496

@felipesanches
Copy link
Collaborator

Thanks, @marcologous

@simoncozens
Copy link
Collaborator

The reason for this is that kerning_for_non_ligated_sequences only parses Format 1 (glyph pair) subtables, not Format 2 (class pair) subtables. So any class-based kerning pairs will not be noticed.

I'm not convinced about this check anyway. It only makes sense for Latin fonts, and it's not clear to me that "has a ligature" equals "needs kerning". I think it's better achieved through other means. ("Is there kerning between Latin pairs which usually have kerning?")

felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 6, 2024
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Dec 6, 2024
felipesanches added a commit that referenced this issue Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants