Skip to content

Commit

Permalink
Previously experimental checks now made effective
Browse files Browse the repository at this point in the history
The dates indicate when each check was originally implemented as temporarily experimental.

Promoted on Universal profile:
  - 2023/Oct/13 com.google.fonts/check/legacy_accents
  - 2023/Oct/20 com.google.fonts/check/arabic_high_hamza

Promoted on Google Fonts profile
  - 2023/Oct/12 com.google.fonts/check/metadata/empty_designer
  - 2023/Oct/13 com.google.fonts/check/family/equal_codepoint_coverage
  - 2023/Nov/02 com.google.fonts/check/glyphsets/shape_languages
  • Loading branch information
felipesanches committed Feb 2, 2024
1 parent e858236 commit 9373332
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 5 deletions.
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,18 @@ A more detailed list of changes is available in the corresponding milestones for
#### Added to the Google Fonts Profile
- **[com.google.fonts/check/metadata/has_tags]:** Check that the font family appears in the tags spreadsheet. (issues #4465 & #4470)

### Previously experimental checks now made effective
The dates indicate when each check was originally implemented as temporarily experimental.

#### Promoted on Universal profile
- 2023/Oct/13: **com.google.fonts/check/legacy_accents**
- 2023/Oct/20: **com.google.fonts/check/arabic_high_hamza**

#### Promoted on Google Fonts profile
- 2023/Oct/12: **com.google.fonts/check/metadata/empty_designer**
- 2023/Oct/13: **com.google.fonts/check/family/equal_codepoint_coverage**
- 2023/Nov/02: **com.google.fonts/check/glyphsets/shape_languages**

### Migration of checks
#### Moved to the Google Fonts profile
- **[com.google.fonts/check/varfont/bold_wght_coord]:** from the Open Type profile. (issue #4436)
Expand Down
3 changes: 0 additions & 3 deletions Lib/fontbakery/profiles/googlefonts.py
Original file line number Diff line number Diff line change
Expand Up @@ -843,7 +843,6 @@ def com_google_fonts_check_metadata_category(family_metadata):
id="com.google.fonts/check/family/equal_codepoint_coverage",
conditions=["are_ttf", "stylenames_are_canonical"],
proposal="https://github.com/fonttools/fontbakery/issues/4180",
experimental="Since 2023/Oct/13",
)
def com_google_fonts_check_family_equal_codepoint_coverage(ttFonts, config):
"""Fonts have equal codepoint coverage"""
Expand Down Expand Up @@ -3527,7 +3526,6 @@ def get_sibling_scripts(target):
"network"
], # use Shaperglot, which uses youseedee, which downloads Unicode files
proposal=["https://github.com/googlefonts/fontbakery/issues/4147"],
experimental="Since 2023/Nov/02",
)
def com_google_fonts_check_glyphsets_shape_languages(ttFont, config):
"""Shapes languages in all GF glyphsets."""
Expand Down Expand Up @@ -7451,7 +7449,6 @@ def com_google_fonts_check_description_noto_has_article(font):
be mentioned in the designer field.
""",
proposal="https://github.com/fonttools/fontbakery/issues/3961",
experimental="Since 2023/Oct/12",
)
def com_google_fonts_check_metadata_empty_designer(family_metadata):
"""At least one designer is declared in METADATA.pb"""
Expand Down
2 changes: 0 additions & 2 deletions Lib/fontbakery/profiles/universal.py
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,6 @@ def com_google_fonts_check_whitespace_ink(ttFont):
U+0060 (GRAVE ACCENT) is used in Markdown to notify code blocks,
and ^ is used as an exponential operator in maths.
""",
experimental="Since 2023/Oct/13",
)
def com_google_fonts_check_legacy_accents(ttFont):
"""Check that legacy accents aren't used in composite glyphs."""
Expand Down Expand Up @@ -841,7 +840,6 @@ def com_google_fonts_check_arabic_spacing_symbols(ttFont):
Not doing so effectively makes the font useless for Jawi and
possibly Kazakh as well.
""",
experimental="Since 2023/Oct/20",
severity=4,
)
def com_google_fonts_check_arabic_high_hamza(ttFont):
Expand Down

0 comments on commit 9373332

Please sign in to comment.