Skip to content

Commit

Permalink
check/gf-axisregistry/fvar_axis_defaults: skip axes which are not in …
Browse files Browse the repository at this point in the history
…GF Axis Registry (#3217)

Co-authored-by: Felipe Corrêa da Silva Sanches <[email protected]>
  • Loading branch information
m4rc1e and felipesanches authored Mar 25, 2021
1 parent e81ba1d commit 59f71ec
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ A more detailed list of changes is available in the corresponding milestones for
- **[com.google.fonts/check/missing_small_caps_glyphs]:** Check small caps glyphs are available (issue #3154)

### Changes to existing checks
- **[com.google.fonts/check/gf-axisregistry/fvar_axis_defaults]:** Only check axes which are in the GF Axis Registry (PR #3217)
- **[com.google.fonts/check/mandatory_avar_table]:** Update rationale to mention that this check may be ignored if axis progressions are linear.
- **[com.google.fonts/check/integer_ppem_if_hinted]:** Format message with newlines.
- **[com.google.fonts/check/STAT/gf-axisregistry]:** Ensure that STAT tables contain Axis Values
Expand Down
2 changes: 2 additions & 0 deletions Lib/fontbakery/profiles/googlefonts.py
Original file line number Diff line number Diff line change
Expand Up @@ -4809,6 +4809,8 @@ def com_google_fonts_check_gf_axisregistry_fvar_axis_defaults(ttFont, GFAxisRegi

passed = True
for axis in ttFont['fvar'].axes:
if axis.axisTag not in GFAxisRegistry:
continue
fallbacks = GFAxisRegistry[axis.axisTag]["fallbacks"]
if axis.defaultValue not in fallbacks.values():
passed = False
Expand Down

0 comments on commit 59f71ec

Please sign in to comment.