-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add launbrowser on run #190
Conversation
And can you put everything in a |
Hey I found that on WSL1 we can not open Host system browser(Or any application, On WSL2 we can) I am trying to find a workaround this. |
@fonsp can you check now |
Looking good! Just some style comments:
|
I'm keen to help finish this off, only confused about @fonsp I also don't see an issue with leaving the error message? Just curious about what it was requested to go, won't argue <3 |
There is currently no built in way to do this. But I opened a PR in JuliaLang too for this, JuliaLang/julia#36425 All the work is already done I don't think there is anything to complete @RocketRoss |
Yeah I see that. Nice! |
Ah you're right, not sure where I got that from. I still have these comments but I can also do them myself sometime? |
Sorry @mgautam98 I'll merge this soon! |
Thanks @mgautam98! |
Towards #179
Opens the default browser with the specified port.
Verified and tested on: