Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pagination/Menu] Flex-wrap should be set for all inline-flex styles #2345

Closed
mvorisek opened this issue Apr 27, 2022 · 7 comments
Closed

[Pagination/Menu] Flex-wrap should be set for all inline-flex styles #2345

mvorisek opened this issue Apr 27, 2022 · 7 comments
Labels
type/feat Any feature requests or improvements
Milestone

Comments

@mvorisek
Copy link
Contributor

mvorisek commented Apr 27, 2022

Bug Report

Some selectors have display: inline-flex; style, but are not wrapped. See actual/expected demo.

adding flex-wrap: wrap; style to these selectors fixes the issue

related with #2157

Expected result

https://jsfiddle.net/d3w6uqnf/

Actual result

https://jsfiddle.net/n18kh4jg/

Screenshot (if possible)

image

Version

2.8.8/latest

@mvorisek mvorisek added state/awaiting-investigation Anything which needs more investigation state/awaiting-triage Any issues or pull requests which haven't yet been triaged type/bug Any issue which is a bug or PR which fixes a bug labels Apr 27, 2022
@lubber-de
Copy link
Member

This also needs proper styling when wrapped, so i suggest to adopt the logic from wrapping buttons we recently implemented by #2217

@lubber-de lubber-de added type/feat Any feature requests or improvements and removed state/awaiting-triage Any issues or pull requests which haven't yet been triaged type/bug Any issue which is a bug or PR which fixes a bug labels Apr 28, 2022
@lubber-de
Copy link
Member

lubber-de commented Apr 28, 2022

I'll tag this as a feature rather than a bug, because it's up to the developer how many page-items are rendered (if it was only 1,2,3..40 a wrapping would not be needed)

@mvorisek
Copy link
Contributor Author

is there any way how can use the latest develop inside jsfiddle.net?

@lubber-de
Copy link
Member

Yes, use the nightly CDN tag
https://cdn.jsdelivr.net/npm/fomantic-ui@nightly/dist/semantic.min.css
https://cdn.jsdelivr.net/npm/fomantic-ui@nightly/dist/semantic.min.js

@mvorisek
Copy link
Contributor Author

Yes, wrapping class is the solution and it should be supported for any component that has display: inline-flex; styling.

demo https://jsfiddle.net/qatcLn73/ (of course, normally there should be no buttons class)

@lubber-de
Copy link
Member

lubber-de commented Jan 23, 2023

As i mentioned above, just wrapping the elements most always breaks the styling, so whenever we would support a "wrapping" class those elements would need more adjustments to also work in all existing variations. (See your own example, it does not look right:

image

For the pagination menu at least the borders would need to be moved to the left instead of the right. We did something similar for List items back then in #353

If we would simply provide a general "wrapping" class into the FUI core, which would just add flex-wrap: wrap, people will start complaining about elements not looking good again (as we are not tailwind which leaves everything up to the user). That's why much more was needed to make it work for buttons in #2217.

@lubber-de
Copy link
Member

Implemented by #2682 for menu component

@lubber-de lubber-de added state/has-pr An issue which has a related PR open and removed state/awaiting-investigation Anything which needs more investigation labels Jan 30, 2023
@lubber-de lubber-de added this to the 2.9.2 milestone Jan 30, 2023
@lubber-de lubber-de added tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed state/has-pr An issue which has a related PR open labels Feb 2, 2023
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feat Any feature requests or improvements
Projects
None yet
Development

No branches or pull requests

2 participants