Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input popup draws over packer display #117

Closed
grimm26 opened this issue Oct 25, 2022 · 1 comment · Fixed by #639
Closed

Input popup draws over packer display #117

grimm26 opened this issue Oct 25, 2022 · 1 comment · Fixed by #639
Labels
bug Something isn't working

Comments

@grimm26
Copy link
Contributor

grimm26 commented Oct 25, 2022

Describe the bug
I run :PackerSync when there is a plugin that has been removed from my config. Packer displays a notification to show what is being removed then prompts for Y|N input. Noice puts the Input prompt over Packer's display of what is being removed.

Noice disabled:
Screenshot from 2022-10-25 10-29-59

Noice enabled
Screenshot from 2022-10-25 10-25-39

Which version of Neovim are you using?
nightly NVIM v0.9.0-dev-155+g771824128

To Reproduce
Steps to reproduce the behavior:

  1. Use packer. Remove a previously installed plugin from your configuration.
  2. Run :PackerClean or "PackerSync inside of nvim with Noice enabled.

Expected Behavior
The display and the input prompt do not cover each other. Either noice somehow picks up Packer's display so that it handles it or it detects that it is there so as not to overlay it. Or something else that keeps displays in view.

Screenshots
See above.
@grimm26 grimm26 added the bug Something isn't working label Oct 25, 2022
@grimm26 grimm26 changed the title Input popup draws over packer prompt Input popup draws over packer display Oct 25, 2022
@folke folke closed this as completed in a810700 Oct 25, 2022
@folke
Copy link
Owner

folke commented Oct 25, 2022

Noice will now automatically move out of the way of existing floating windows

@ranjithshegde ranjithshegde mentioned this issue Oct 26, 2022
Merged
folke pushed a commit that referenced this issue Oct 26, 2022
@ranjithshegde
fix(smart_move): Dont move cmdline view (#123)
3da3f6d 
\#117 Added the smart_move function that avoids overlap. But it
introduced some bugs with cmdline view set to `cmdline`. To avoid
overlap with `mini` or other views, the cmdline itself would move to odd
locations. This fixes that issue.
@github-actions github-actions bot mentioned this issue Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(main): release 2.0.0 folke/noice.nvim
2 participants
@grimm26 @folke