-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): refresh stale prefs #88
Open
Ajaymamtora
wants to merge
3
commits into
folke:main
Choose a base branch
from
Ajaymamtora:feature/refresh_stale_prefs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(settings): refresh state
This PR is stale because it has been open 30 days with no activity. |
. |
This PR is stale because it has been open 30 days with no activity. |
. |
This PR is stale because it has been open 30 days with no activity. |
. |
This PR is stale because it has been open 30 days with no activity. |
. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(settings): refresh state
Description
The state of the plugin internally does not always reflect the local and global config files. For example, if I define a an exclusions property in my local config, then load everything with neoconf. Then I remove an item and use neoconf.get(), it will return the old state of the config. Using this refresh method re-fetches the items from the local and global file.
I need this because I created a binding in neotree to toggle a node as excluded. I change the highlights as excluded using the component field:
However this would never work properly without me being able to reset the internal state so that the item is removed from neoconf.
Now each time I invoke the binding that toggles this, the node is correctly toggled from the exclusions list in the local config file using my own separate json parsing.
Related Issue(s)
#61 61
Screenshots