Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: window centering isn't correct when border isn't equal 'none' #812

Closed
3 tasks done
dtcyganok opened this issue May 21, 2023 · 0 comments · Fixed by #809
Closed
3 tasks done

bug: window centering isn't correct when border isn't equal 'none' #812

dtcyganok opened this issue May 21, 2023 · 0 comments · Fixed by #809
Labels
bug Something isn't working

Comments

@dtcyganok
Copy link

Did you check docs and existing issues?

  • I have read all the lazy.nvim docs
  • I have searched the existing issues of lazy.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

v0.9.0

Operating system/version

Linux

Describe the bug

The window centering isn't correct when border isn't equal 'none'. Perhaps the window position calculation doesn't include logic about borders.

Steps To Reproduce

Set the ui option border = 'rounded'

Expected Behavior

The window centered correctly.

Repro

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
  ui = {
    border = 'rounded',
  },
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here
@dtcyganok dtcyganok added the bug Something isn't working label May 21, 2023
@folke folke closed this as completed in 451f217 May 21, 2023
folke added a commit to folke/snacks.nvim that referenced this issue Nov 12, 2024
## Description

<!-- Describe the big picture of your changes to communicate to the
maintainers
  why we should accept this pull request. -->
The window position is not correctly centered when position is set to
`float` and border isn't `none`. I found [a similar
issue](folke/lazy.nvim#812) in
[lazy.nvim](https://github.com/folke/lazy.nvim) along with [your
fix](folke/lazy.nvim@451f217)
there, so I have applied the same fix here. Thank you for your work!

## Related Issue(s)
folke/lazy.nvim#812

<!--
  If this PR fixes any issues, please link to the issue here.
  - Fixes #<issue_number>
-->

## Screenshots

<!-- Add screenshots of the changes if applicable. -->

### Before
<img width="2240" alt="image"
src="https://github.com/user-attachments/assets/6e5eeb7b-7993-4ab5-a40e-c77021a5ccb0">

### After
<img width="2240" alt="image"
src="https://github.com/user-attachments/assets/66ad76ab-8ca2-446f-afce-b18599313319">

---------

Co-authored-by: Folke Lemaitre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant