Lock karma-webpack to 2.0.6 to resolve 404's running unit tests #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 404's running Karma unit tests discussed in STRIPES-494.
The cause appears to a defect found in versions of
karma-webpackgreater than 2.0.6.codymikol/karma-webpack#289
The 404's may be related to
/_karma_webpack_/paths used for the in-memory file system. Comparing the verbose webpack output of my NPM-installed CLI with that of my Yarn-installed CLI, I came across a discrepancy inPublicPathwith the Yarn version was pointing to a nonexistent directory in the temporary/var/folders/...path on disk.As a global NPM install, the existing package-lock.json is respected which happens to have karma-webpack already set at 2.0.6. Once we started using Stripes CLI with ui-eholdings via Yarn, the latest version of karma-webpack was pulled in surfacing this error.