Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain optional fromModuleVersion #962

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Explain optional fromModuleVersion #962

merged 2 commits into from
Aug 17, 2021

Conversation

julianladisch
Copy link
Contributor

No description provided.

steveellis
steveellis approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@steveellis steveellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proof read text and looks good to me. Only noticed that some of numbered items in Readme.md (the text after the '-') start with a capital letter and some do not. Also some end with a period and some do not as well.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@julianladisch julianladisch merged commit 6976918 into master Aug 17, 2021
@julianladisch julianladisch deleted the explain-optional-fromModuleVersion branch August 17, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdickmeiss adamdickmeiss adamdickmeiss approved these changes

@steveellis steveellis steveellis approved these changes

@hjiebsco hjiebsco Awaiting requested review from hjiebsco

@MikhailFokanov MikhailFokanov Awaiting requested review from MikhailFokanov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianladisch @steveellis @adamdickmeiss