RMB-975: Define DB_HOST_ASYNC_READER, DB_PORT_ASYNC_READER #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
domain-models-runtime/src/main/java/org/folio/rest/persist/PostgresClient.java
Outdated
Show resolved
Hide resolved
domain-models-runtime/src/main/java/org/folio/rest/persist/PostgresClientInitializer.java
Outdated
Show resolved
Hide resolved
domain-models-runtime/src/main/java/org/folio/rest/persist/PostgresClientInitializer.java
Outdated
Show resolved
Hide resolved
domain-models-runtime/src/test/java/org/folio/rest/persist/PostgresClientTest.java
Outdated
Show resolved
Hide resolved
domain-models-runtime/src/main/java/org/folio/rest/persist/PostgresClientWithAsyncReadConn.java
Show resolved
Hide resolved
# Conflicts: # domain-models-runtime/src/main/java/org/folio/rest/persist/PostgresClient.java
- Added javadoc to async reader class - Fixed up readme - Simplified conditions in PostgresClientInitializer - Consolidated two tests into one
README.md
Outdated
| The environment variables `DB_HOST_READER` and `DB_PORT_READER` are for the [Read and write database instances setup](#read-and-write-database-instances-setup). | ||
| The environment variables `DB_HOST_READER` and `DB_PORT_READER` are for the synchronously replicated [Read and write database instances setup](#read-and-write-database-instances-setup). | ||
|
|
||
| The environment variables `DB_HOST_ASYNC_READER` and `DB_PORT_ASYNC_READER` are for the [Asynchronously replicated read and write database instances setup](#asynchronously-replicated-read-and-write-database-instances-setup). |
There was a problem hiding this comment.
#asynchronously-replicated-read-and-write-database-instances-setup doesn't exist.
There was a problem hiding this comment.
The link doesn't work because the anchor doesn't exist on this README page.
There was a problem hiding this comment.
Sorry I missed this one. Fixed.
|
julianladisch
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/RMB-975
Breaks logic for constructing the three types of hosts out into its own class since it is now used by
PostgresClientandPostgresClientWithAsyncReadConn.PostgresClientWithAsyncReadConnis responsible for setting the read host to be the async reader. Users can use thePostgresClientreturned from PostgresClientWithAsyncReadConn.getInstanceas a drop in replacement ofPostgresClient`.I opted to use inheritance rather than composition to make
PostgresClientWithAsyncReadConnsince extending it didn't require wrapping of all of theSELECTtype of methods. If there are certain methods we don't want to support, it is easy enough to add overrides and throw an unsupported operation exception if needed.