[MODEBSNET-51] - Update to Java 17./Update the module to Spring boot v3.0.0 and identify issues. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose this PR should be taken into account https://github.com/folio-org/folio-spring-base/pull/77/files |
I have fixed issue next commit Update the module to Spring boot v3.0.0 and identify issues. |
|
I am facing this issue after upgrading spring boot 3.0.0, I cannot find the solution |
azizbekxm
requested review from
TarasSpashchenko,
tatsiana-tarhonskaya,
humonest-one,
KyryloShulzhenko,
ArtHov,
MurodjonMukhamadaliev,
bekhzodkurbonboev and
grabsefx
| @@ -13,7 +13,7 @@ buildMvn { | |||
| buildDocker { | |||
| publishMaster = 'yes' | |||
| healthChk = 'no' | |||
| healthChkCmd = 'curl -sS --fail -o /dev/null http://localhost:8081/apidocs/ || exit 1' | |||
| healthChkCmd = 'wget --no-verbose --tries=1 --spider http://localhost:8081/admin/health || exit 1' | |||
There was a problem hiding this comment.
is changing "apidocs/" to "admin/health" intended?
There was a problem hiding this comment.
fisrt I little bit confuse, then I saw there in this https://issues.folio.org/browse/FOLIO-3407 place and I also changed it
There was a problem hiding this comment.
please make sure this url is available in the module (looks like you won't see the error during build anyway since healthcheck is disabled: healthChk = 'no')
There was a problem hiding this comment.
Ok, looks like these url avilable
grabsefx
changed the title
|
@grabsefx Big Thanks for helping. it solves the issue |
azizbekxm
commented
Jan 20, 2023
| import org.hamcrest.DiagnosingMatcher; | ||
| import org.skyscreamer.jsonassert.JSONCompare; | ||
| import org.skyscreamer.jsonassert.JSONCompareMode; | ||
| import org.skyscreamer.jsonassert.JSONCompareResult; | ||
|
|
There was a problem hiding this comment.
These are not used so deleted
There was a problem hiding this comment.
In case it wasn't affected by dependenies update, such changes should be done in separate commits
azizbekxm
commented
Jan 20, 2023
| import org.springframework.test.context.TestPropertySource; | ||
| import org.springframework.transaction.annotation.EnableTransactionManagement; | ||
| import org.springframework.util.SocketUtils; | ||
| import org.springframework.test.util.TestSocketUtils; | ||
|
|
There was a problem hiding this comment.
In spring boot, LocalServerPort changed to test package
SocketUtils is replaced with TestSocketUtils
spring-projects/spring-framework#28210
pom.xml
Outdated
| <springdoc-openapi-ui.version>1.6.14</springdoc-openapi-ui.version> | ||
| <jackson-databind-nullable.version>0.2.4</jackson-databind-nullable.version> | ||
| <!-- Plugin properties --> | ||
| <spring-boot-maven-plugin.version>2.7.3</spring-boot-maven-plugin.version> |
There was a problem hiding this comment.
shouldn't it be updated to third?
… issues removed unessary dependency
… issues removed unessary dependency version
|
Kudos, SonarCloud Quality Gate passed! |
|
|
grabsefx
approved these changes
Jan 27, 2023
SerhiiNosko
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://issues.folio.org/browse/MODEBSNET-52
https://issues.folio.org/browse/MODEBSNET-51
Approach
TODOS and Open Questions
Learning
Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate action.
If there are breaking changes, please STOP and consider the following:
Ideally, all the PRs involved in breaking changes would be merged on the same day
to avoid breaking the folio-testing environment.
Communication is paramount if that is to be achieved,
especially as the number of inter-module and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems,
ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.