Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Releases are not shown (except to repo owner) #346

Closed
1 of 2 tasks
fohrloop opened this issue Jun 4, 2024 · 3 comments · Fixed by #347 or #350
Closed
1 of 2 tasks

GitHub Releases are not shown (except to repo owner) #346

fohrloop opened this issue Jun 4, 2024 · 3 comments · Fixed by #347 or #350
Assignees
@fohrloop
Labels
Type: Bug Something isn't working Type: Maintenance Code quality, updating dependencies, pipelines, ...

Comments

@fohrloop
Copy link
Owner

fohrloop commented Jun 4, 2024 •
edited
Loading

In https://github.com/fohrloop/wakepy/releases all releases are marked as Drafts and they're not connected to any existing tags.

This requires two fixes:

  • Publish the already made releases under the correct tags
  • Fix the publish-a-release workflow to make the releases correctly from now on

Possibly related: #328

image
@fohrloop fohrloop changed the title GitHub Releases are not connected to tags GitHub Releases are not connected to tags and are shown as Drafts Jun 4, 2024
@fohrloop fohrloop added Type: Bug Something isn't working Type: Maintenance Code quality, updating dependencies, pipelines, ... labels Jun 4, 2024
@fohrloop fohrloop changed the title GitHub Releases are not connected to tags and are shown as Drafts GitHub Releases are not shown (except to repo owner) Jun 4, 2024
@fohrloop fohrloop self-assigned this Jun 4, 2024
@fohrloop fohrloop mentioned this issue Jun 4, 2024
Merged
fohrloop added a commit that referenced this issue Jun 4, 2024
@fohrloop
Try: Run GitHub Releases only on tags which start with "v" (#347)
c61a0ea 
This tries to fix #346

* Check if running with tag which starts with "v"
* Add title: wakepy x.y.z to GitHub Releases from the tag
* Release as draft.
@fohrloop fohrloop reopened this Jun 4, 2024
@fohrloop
Copy link
Owner Author

fohrloop commented Jun 4, 2024

Okay now it's not possible to run the release workflow in any other way than selecting a tag which starts with "v". Or, at least running it on main won't work:

image

@fohrloop
Copy link
Owner Author

fohrloop commented Jun 4, 2024 •
edited
Loading

Disabling pypi publishing and creating a GitHub release with version number 0.0.1 for test purposes

Related workflow run: https://github.com/fohrloop/wakepy/actions/runs/9373045098 (after #348)

Creating another GitHub release with version number 0.0.2 for test purposes.

Related workflow run: https://github.com/fohrloop/wakepy/actions/runs/9373171631 (after #348)

@fohrloop fohrloop mentioned this issue Jun 4, 2024
Merged
fohrloop added a commit that referenced this issue Jun 4, 2024
@fohrloop
disable pypi publishing for a test (#348)
c66dba2 
This is for: #346 (wip)

will be reverted soon.
@fohrloop fohrloop mentioned this issue Jun 4, 2024
Merged
fohrloop added a commit that referenced this issue Jun 4, 2024
@fohrloop
Another trial for Issue 346 (#349)
ddeb791 
This is for #346

Try to create the release title from github.ref_name.
@fohrloop
Copy link
Owner Author

fohrloop commented Jun 4, 2024

It seems to work now!

  • Title is correct
  • Tag is correct
  • Status is Draft (waits for changelog edit)

image

Have to still add the pypi publishing back

@fohrloop fohrloop mentioned this issue Jun 4, 2024
Merged
fohrloop added a commit that referenced this issue Jun 4, 2024
@fohrloop
add PyPI publishing job back + update changelog (#350)
3b32ba7 
With #347, #348, #349 closes #346 and #328

* add PyPI publishing job back & update changelog
@fohrloop fohrloop mentioned this issue Jun 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fohrloop fohrloop

Labels
Type: Bug Something isn't working Type: Maintenance Code quality, updating dependencies, pipelines, ...
Projects
None yet
Milestone
No milestone
1 participant
@fohrloop