Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to src layout #234

Merged
merged 8 commits into from
Apr 1, 2024
Merged

Convert to src layout #234

merged 8 commits into from
Apr 1, 2024

Conversation

fohrloop
Copy link
Owner

@fohrloop fohrloop commented Apr 1, 2024

Previously, was using a flat layout. Convert to src layout.

Motivation: Had some issues running tox, which should have been testing the built wheels. Instead, it was running the tests against the source tree, and unit tests passed with empty wheels. Using a src layout makes it harder to have problems like that.

See also: https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/

fohrloop added 8 commits April 1, 2024 13:31
was: --cov wakepy
now: --cov {envsitepackagesdir}/wakepy
The site-packages were omitted. This was the reason for the previous strange behavior
of test coverage; 0% coverages (only) when running tox in repo root.
@fohrloop fohrloop merged commit 9b5db10 into dev Apr 1, 2024
7 checks passed
@fohrloop fohrloop deleted the convert-to-src-layout branch April 3, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant