Use python -m build to create wheels for tox and only do it once per tox invocation
#231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously: when running tox, it created wheels directly from the source tree and installed Now: When running tox, always run against a wheel which is created from sdist created from the source tree (using python -m build). This way (1) also the sdist is tested and (2) the same exact wheel files which are uploaded to PyPI will be tested in the unit tests. In addition, start using the .pkg_external tox environment for building the wheel -- with a small adjustment: Always only build the wheel once (makes the tests run faster).
fohrloop
force-pushed
the
improve-tox-and-build
branch
from
9b6ca2f to
2714805
Compare
fohrloop
changed the title
python -m build to create wheels for tox and only do it once
fohrloop
changed the title
python -m build to create wheels for tox and only do it oncepython -m build to create wheels for tox and only do it once per tox invocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: when running tox, it created wheels directly from the source tree and installed
Now: When running tox, always run against a wheel which is created from sdist created from the source tree (using python -m build). This way (1) also the sdist is tested and (2) the same exact wheel files which are uploaded to PyPI will be tested in the unit tests.
In addition, start using the .pkg_external tox environment for building the wheel -- with a small adjustment: Always only build the wheel once (makes the tests run faster).