Set min required test coverage to 100 percent + conditional coverage #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
saw failing pipeline succesfully (only 99.91% coverage). Removing the dummy function. |
|
Hmm. Of course the code coverage percentage is platform specific! Have to check out later if there's something to make it feasible to try to get 100% test coverage on all platforms. |
This should fix the platform test coverage
The omit syntax of coverage-conditional-plugin seems to require toml config
fohrloop
changed the title
was: show-test-coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
100% branch coverage is the bare minimum for wakepy. Individual lines and branches will ideally be covered in multiple tests.