Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The GitHub workflow for publishing a release does not work #300

Closed
fohrloop opened this issue May 25, 2024 · 1 comment · Fixed by #301
Closed

The GitHub workflow for publishing a release does not work #300

fohrloop opened this issue May 25, 2024 · 1 comment · Fixed by #301
Labels
Type: Bug Something isn't working Type: Maintenance Code quality, updating dependencies, pipelines, ...

Comments

@fohrloop
Copy link
Owner

The Github workflow for publishing a release (.github/workflows/publish-a-release.yml ) does not work.

  • It triggers when PR is merged to main, but does not run the release step as those start like this:
  publish-to-github-releases:
    name: Publish wakepy to GitHub
    # only publish to GitHub Releases on tag pushes
    if: startsWith(github.ref, 'refs/tags/')
  • It can be triggered manually, but does not run the release step for the same above mentioned reason.
  • It will not trigger on tag push. The yaml starts with:
'on':
  workflow_dispatch:
  push:
    branches:
      - main

@fohrloop fohrloop added Type: Bug Something isn't working Type: Maintenance Code quality, updating dependencies, pipelines, ... labels May 25, 2024
@fohrloop
Copy link
Owner Author

Going to change this so that it's only triggered with workflow_dispatch. The workflow_dispatch action is allowed by only the persons with write access to the repo (ref: https://github.com/orgs/community/discussions/26622).

fohrloop added a commit that referenced this issue May 25, 2024
Fixes #300

Changes how the publish-a-release workflow is triggered.

Previously
* PR merged to main or manual trigger
* Release required tag push to main -> never released.

Now:
* Only manual trigger
* Release does not require a tag push -> Triggering the workflow
  manually will build and release.
fohrloop added a commit that referenced this issue May 25, 2024
Fixes #300

Changes how the publish-a-release workflow is triggered.

Previously
* PR merged to main or manual trigger
* Release required tag push to main -> never released.

Now:
* Only manual trigger
* Release does not require a tag push -> Triggering the workflow
  manually will build and release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working Type: Maintenance Code quality, updating dependencies, pipelines, ...
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant