Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spruce up attaching and detaching disks on running servers #613

Merged
merged 5 commits into from
Dec 2, 2023

Conversation

rchekaluk
Copy link

As a new fog-google user, I encountered various issues in dynamically attaching and detaching disks against a running server, namely:

@Temikus Temikus mentioned this pull request Dec 2, 2023
@Temikus
Copy link
Member

Temikus commented Dec 2, 2023

Thank you very much! Changes LGTM 👍

There's a cleanup routine needed to clean up the drives in integration tests but I'll add that myself. Not waiting for workflows to finish as we're having some issues with our GCP project at the moment and I don't want to block you.

@Temikus Temikus merged commit 40a6fc7 into fog:master Dec 2, 2023
5 of 17 checks passed
@rchekaluk rchekaluk deleted the detach_disk_users branch December 6, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants