Allow fog-core 2.0

[jaredbeck]

The fog-core changelog entry for 2.0 says:

fix association reload drop ruby <2 support fix net-ssh usage add mime-type dependency

[jaredbeck]

Test failure:

  undefined method `all_associations_and_attributes' for nil:NilClass (NoMethodError)
        /home/travis/.rvm/gems/ruby-2.0.0-p648/gems/fog-core-2.0.0/lib/fog/core/model.rb:49:in `reload'
        /home/travis/.rvm/gems/ruby-2.0.0-p648/gems/fog-core-2.0.0/lib/fog/core/model.rb:71:in `block in wait_for'
        /home/travis/.rvm/gems/ruby-2.0.0-p648/gems/fog-core-2.0.0/lib/fog/core/wait_for.rb:7:in `block in wait_for'
        /home/travis/.rvm/gems/ruby-2.0.0-p648/gems/fog-core-2.0.0/lib/fog/core/wait_for.rb:6:in `loop'
        /home/travis/.rvm/gems/ruby-2.0.0-p648/gems/fog-core-2.0.0/lib/fog/core/wait_for.rb:6:in `wait_for'
        /home/travis/.rvm/gems/ruby-2.0.0-p648/gems/fog-core-2.0.0/lib/fog/core/model.rb:70:in `wait_for'
        tests/models/compute/address_tests.rb:6:in `block (2 levels) in <top (required)>'
        tests/helpers/model_helper.rb:12:in `block in model_tests'
...

Might have something to do with that "fix association reload" part of the fog-core changelog entry?

[geemus]

Unfortunately, I forget some of the specifics here. @plribeiro3000 do you perhaps recall enough to help provide guidance here? Thanks!

[plribeiro3000]

Damm. sorry i'm late here.

I think i lost this notification by email. Will check it now.

[plribeiro3000]

Hmmm. I believe this has nothing to do with fog-core.

Looking at the implementation:

https://github.com/fog/fog-core/blob/ec1a09ee986fd4bd37dbd0b33ae0f260d57e3cf7/lib/fog/core/model.rb#L47-L49

It seems that the object trying to be reloaded do not exist.

Maybe this test is doing a reload on a non existent object? Or maybe we should check if identity is not nil before trying to get it again and reload?

[plribeiro3000]

Going a little deeper:

This is where it actually calls reload:

fog-aws/tests/models/compute/address_tests.rb

Line 14 in 61b3dbb

@server.reload

And it does not seem as the tests are running against Mock.

fog-aws/tests/helper.rb

Lines 1 to 29 in 61b3dbb

	begin
	require 'simplecov'
	SimpleCov.start
	SimpleCov.command_name "Shindo"
	rescue LoadError => e
	$stderr.puts "not recording test coverage: #{e.inspect}"
	end
	require File.expand_path('../../lib/fog/aws', __FILE__)
	Bundler.require(:test)
	Excon.defaults.merge!(:debug_request => true, :debug_response => true)
	require File.expand_path(File.join(File.dirname(__FILE__), 'helpers', 'mock_helper'))
	# This overrides the default 600 seconds timeout during live test runs
	unless Fog.mocking?
	Fog.timeout = ENV['FOG_TEST_TIMEOUT'] || 2_000
	Fog::Logger.warning "Setting default fog timeout to #{Fog.timeout} seconds"
	end
	def lorem_file
	File.open(File.dirname(__FILE__) + '/lorem.txt', 'r')
	end
	def array_differences(array_a, array_b)
	(array_a - array_b) | (array_b - array_a)
	end

[lanej]

Closing in favor of #433