Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditions for automatically skipping NPCs #61

Open
focustense opened this issue Jul 22, 2021 · 2 comments
Open

Conditions for automatically skipping NPCs #61

focustense opened this issue Jul 22, 2021 · 2 comments
Labels
easynpc Issues/requests relating the EasyNPC app enhancement New feature or request

Comments

@focustense
Copy link
Owner

Was just looking at a few examples and this came to mind. There's a case where EasyNPC is doing nothing interesting with an NPC, and in this case it should skip them: When the default plugin is the last plugin in the load order to modify that NPC, and either of the following are true:

  • The face plugin is the same as the default plugin
  • The face plugin is the originating master and the default plugin doesn't modify face attributes (has same face as the originator)

In this case, EasyNPC would just be creating an ITM, and possibly a useless facegen to boot. Even if the default plugin has a facegen, despite not having face edits in the plugin, EasyNPC still doesn't need to copy it because, as a master, the default plugin/mod is going to remain installed.

It's minor, but this would have helped with workarounds for some of the children issues in #60, could have been a way to prevent those children from ever being added to the output mod, but without this feature that won't work.

This is separate from the request to manually exclude NPCs. This would automatically exclude NPCs that aren't being modified in any interesting way.

@focustense focustense added enhancement New feature or request easynpc Issues/requests relating the EasyNPC app labels Jul 22, 2021
@Killing-J0ke
Copy link

Being able to manually skip any character would be useful too.

focustense added a commit that referenced this issue Aug 1, 2021
The component will be used for top level info in new reports e.g. pre- and post-build reports (#37, #17, #51, #61, #78, etc.)

This is especially for the pre-build report, for which the flow is becoming too unwieldy and needs to be redesigned.
@llyarc
Copy link

llyarc commented Aug 9, 2021

If one npc template has another npc, using a different face in this case may cause problems. I'm not quite sure how the template works exactly but it should be a point worth noting, maybe skipping them or giving them the same face automatically

focustense added a commit that referenced this issue Aug 11, 2021
This is the minimum required to display and interact with a profile based on the new analysis and mod repository code, not counting the XAML changes to the main Profile page. Most of the WPF components are just extracted from the original Profile page, but made standalone in order to provide better view/viewmodel encapsulation.

Not "fully" tested but all of the basic flows seem to work when integrated with the main app (TBD in a later commit).

#85 #64 #61 #51 #49 #37 #26 #22 (doesn't complete any of these, but advances all of them)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easynpc Issues/requests relating the EasyNPC app enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants