Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate sonar coverage #420

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Aggregate sonar coverage #420

wants to merge 1 commit into from

Conversation

derTobsch
Copy link
Contributor

@derTobsch derTobsch commented Jan 12, 2024

refs #419

atm we do not track jackson, so we will provide a report aggregate module that will cover all modules for us.

@derTobsch derTobsch force-pushed the fix-coverage-report branch 5 times, most recently from 7eae307 to a7a7191 Compare January 12, 2024 14:43
@derTobsch derTobsch marked this pull request as draft January 12, 2024 14:51
@derTobsch derTobsch changed the title Fix sonar coverage Aggregate sonar coverage Jan 12, 2024
@derTobsch derTobsch force-pushed the fix-coverage-report branch 3 times, most recently from c91133f to 267ad7d Compare January 15, 2024 09:19
Copy link

sonarcloud bot commented Jan 15, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@derTobsch derTobsch force-pushed the fix-coverage-report branch 2 times, most recently from a1861ba to f2d68a6 Compare January 23, 2024 13:16
@XSpielinbox
Copy link
Contributor

Will this also fix the never ending failing actions in forks, e.g. https://github.com/XSpielinbox/jollyday/actions or what does one have to do there to fix this?

@derTobsch
Copy link
Contributor Author

Will this also fix the never ending failing actions in forks, e.g. https://github.com/XSpielinbox/jollyday/actions or what does one have to do there to fix this?

No this does not fix your problem. Your problem is that no sonar token is provided and therefore it cannot run sonar.

This will fix that all module reports will be aggregated. But I need to think about a good testing modularity, so that I do not need to write duplicated tests.

@XSpielinbox
Copy link
Contributor

XSpielinbox commented Feb 1, 2024

No this does not fix your problem. Your problem is that no sonar token is provided and therefore it cannot run sonar.

Ah, ok. Is there a possibility to disable these sonar test in forks as I don't see an option to provide a sonar without having an account there?

@derTobsch
Copy link
Contributor Author

No this does not fix your problem. Your problem is that no sonar token is provided and therefore it cannot run sonar.

Ah, ok. Is there a possibility to disable these sonar test as I don't see an option to provide a sonar without having an account there?

yes of course. I will look into it.

@derTobsch
Copy link
Contributor Author

@XSpielinbox see #448 please test it :)

@XSpielinbox
Copy link
Contributor

@XSpielinbox see #448 please test it :)

Yes, it works now! Thank you!

@derTobsch derTobsch force-pushed the fix-coverage-report branch 2 times, most recently from 9630364 to 2700ec9 Compare March 5, 2024 08:47
@derTobsch derTobsch added this to the 0.27.0 milestone Mar 6, 2024
@derTobsch derTobsch marked this pull request as ready for review March 6, 2024 19:58
@derTobsch derTobsch added the type: enhancement A general enhancement label Mar 6, 2024
@derTobsch derTobsch force-pushed the fix-coverage-report branch 3 times, most recently from 092188c to 78e8e8c Compare March 6, 2024 20:10
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@derTobsch derTobsch marked this pull request as draft March 6, 2024 20:38
@derTobsch derTobsch removed this from the 0.27.0 milestone Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants