Fix orphan, placeholder, tag-explorer counts #1131
Conversation
| treeView.title = baseTitle + ` (${foam.tags.tags.size})`; | ||
| }) | ||
| ); | ||
| foam.tags.onDidUpdate(() => provider.refresh()); |
There was a problem hiding this comment.
I actually didn't run into issues with tag count becoming out of sync during my testing, but I still made this change as I believe there could be a race condition. The title could be wrong if provider.refresh() doesn't complete before title is generated. Thoughts?
There was a problem hiding this comment.
There is no race condition here because we don't use the provider to compute the number, but the foam.tags object directly (also this is the reason why you didn't run into issues in the first place)
| treeView.title = baseTitle + ` (${foam.tags.tags.size})`; | ||
| }) | ||
| ); | ||
| foam.tags.onDidUpdate(() => provider.refresh()); |
There was a problem hiding this comment.
There is no race condition here because we don't use the provider to compute the number, but the foam.tags object directly (also this is the reason why you didn't run into issues in the first place)
I think there's a slight bug with change 7a2756e, where the counts are out of sync with the actual number of entries
To reproduce in new project:
Orphans (2)even though it only has note1 and placeholders panel saysPlaceholders (0)with the note3 entryI believe we just need to tweak the subscription logic so the panel title is set after we do the calculations for each panel.