Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update to python 3 and Alfred 4 and 5 #54

Merged
merged 1 commit into from
Mar 30, 2023
Merged

refactor: Update to python 3 and Alfred 4 and 5 #54

merged 1 commit into from
Mar 30, 2023

Conversation

harrtho
Copy link
Contributor

@harrtho harrtho commented Dec 22, 2022

Resolves #53
Resolves #52

@fniephaus
Copy link
Owner

Hi @harrtho, thanks for the PR! I don't have access to a machine running Monterey at the moment, but I will take a look in the next two weeks. If anyone can give this a try, that'd be great too.

Cheers,
Fabio

@harrtho
Copy link
Contributor Author

harrtho commented Dec 30, 2022

Hi @fniephaus no problem. I figured out recently (again), that the absolute Homebrew path to python3 is different on Intel and ARM Macs. Therefore I fixed it this in the pull request.

It would be nice if somebody with an ARM Mac can test the refactored source code as I'm still working on an Intel Mac.

I made a demo release on the fork to simplify the test process: https://github.com/harrtho/alfred-homebrew/releases/tag/v5.5

@nhat
Copy link

nhat commented Jan 10, 2023

Thanks @harrtho! Works fine for me on an M1 MBP.

I stopped using this workflow after switching to a M1 Mac and just discovered your PR now.

@jim465
Copy link

jim465 commented Jan 20, 2023

Also tested on M1Pro and it works.
Thanks!

@brandonwie
Copy link

Tested on M2 Pro and it works well. Thanks.

@fniephaus fniephaus merged commit 94e75dd into fniephaus:master Mar 30, 2023
@fniephaus
Copy link
Owner

Thanks again for the contribution and apologies for the delay. I've merged this and pushed a new v6.0. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Homebrew python3 version Not working in Monterey 12.3
5 participants