-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow compiling and using as DLL in windows #502
Allow compiling and using as DLL in windows #502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR! Mostly looks good, just one minor comment.
fmt/printf.h
Outdated
spec.type_ = internal::DefaultType().visit(arg); | ||
|
||
// Avoid warning for wchar_t | ||
spec.type_ = char(internal::DefaultType().visit(arg)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change the return values in DefaultType
instead of using a cast here?
Changed the return type of DefaultType to 'char' as requested. Also I needed to change the assertion in The reason was that Hopefully I did not misinterpret the intention of the test. |
Maybe it is possible to add appveyor tests with BUILD_SHARED_LIBS=ON? |
@AndreasSchoenle What do you mean by |
* printf.h fixed to compile clean - need to check whether this is the right thing to do * fix warnings and errors in test compiles with BUILD_SHARED_LIBS * did requested changes and added one change to allow all tests to succeed in windows DLL
* fix warnings and errors in test compiles with BUILD_SHARED_LIBS * did requested changes and added one change to allow all tests to succeed in windows DLL (cherry picked from commit 79f11db)
* fix warnings and errors in test compiles with BUILD_SHARED_LIBS * did requested changes and added one change to allow all tests to succeed in windows DLL (cherry picked from commit 79f11db)
Removes warnings and errors when compiling in VS 2015 with BUILD_SHARED_LIBS set to "ON".