Add more emphases #2303
Closed
Add more emphases #2303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foonathan
reviewed
May 21, 2021
| @@ -399,7 +407,7 @@ template <typename Char> struct ansi_color_escape { | |||
| return; | |||
| } | |||
|
|
|||
| for (int i = 0; i < 7; i++) { | |||
| for (int i = 0; i < 8; i++) { | |||
There was a problem hiding this comment.
I don't understand the buffer logic completely, but you've increased the buffer from a 3 * 4 to a 3 * 8 yet change this loop index from 7 to 8? It might be a good idea to introduce some constants...
There was a problem hiding this comment.
to introduce some constants
Count of emphasis enum members?
There was a problem hiding this comment.
I'll continue tomorrow. Need to sleep. :)
|
Sorry, my family tested positive for COVID so I have other concerns now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2302.