Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few warnings I was seeing compiling with clang:
-Wsigned-enum-bitfield
from using standard enums in a bitfield, fixed by giving them an unsigned underlying type.-Wundefined-func-template
from templates without definitions, fixed by addingextern template
declarations.-Wsign-conversion
from constructing astring_view
with anint
size, fixed withinternal::to_unsigned
.I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.