Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<utility> included twice in format.h, once unconditionally, the other under #if FMT_USE_RVALUE_REFERENCES #479

Closed
ddevienne opened this issue Mar 1, 2017 · 1 comment
Closed

<utility> included twice in format.h, once unconditionally, the other under #if FMT_USE_RVALUE_REFERENCES #479

ddevienne opened this issue Mar 1, 2017 · 1 comment

Comments

@ddevienne
Copy link

Noticed in 3.0.1 (line 41 and line 156), but latest code seems to be the same. FYI. --DD
@ddevienne ddevienne changed the title <utility> includes twice in format.h, once unconditionally, the other under #if FMT_USE_RVALUE_REFERENCES <utility> included twice in format.h, once unconditionally, the other under #if FMT_USE_RVALUE_REFERENCES Mar 1, 2017
vitaut added a commit that referenced this issue Mar 3, 2017
@vitaut
Remove redundant include (#479)
cc736e7
@vitaut
Copy link
Contributor

vitaut commented Mar 3, 2017

You are right, the second include is redundant. Removed in cc736e7, thanks!

@vitaut vitaut closed this as completed Mar 3, 2017
foonathan pushed a commit that referenced this issue Jun 8, 2017
@vitaut @foonathan
Remove redundant include (#479)
9270e66 
(cherry picked from commit cc736e7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ddevienne @vitaut