Fix handling of types with to_string_view and formatter specialization (

#2180)
fmtlib · Mar 18, 2021 · 15d6145 · 15d6145
1 parent a6408a3
commit 15d6145
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/include/fmt/args.h b/include/fmt/args.h
@@ -95,7 +95,9 @@ class dynamic_format_arg_store
   };
 
   template <typename T>
-  using stored_type = conditional_t<detail::is_string<T>::value,
+  using stored_type = conditional_t<detail::is_string<T>::value &&
+                                        !has_formatter<T, Context>::value &&
+                                        !detail::is_reference_wrapper<T>::value,
                                     std::basic_string<char_type>, T>;
 
   // Storage of basic_format_arg must be contiguous.

diff --git a/test/args-test.cc b/test/args-test.cc
@@ -32,6 +32,8 @@ TEST(ArgsTest, StringsAndRefs) {
 
 struct custom_type {
   int i = 0;
+
+  friend std::string_view to_string_view(const custom_type&) { return ""; }
 };
 
 FMT_BEGIN_NAMESPACE