Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pyramid_level_coord argument to plot_well() #5

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

silvbarb
Copy link
Collaborator

@silvbarb silvbarb commented Feb 8, 2024

Should we also allow pyramid_level_coord for plot_well()?
That would mean propagating the argument to get_image_ROI and get_label_ROI.
I added to the tests as well, but please have a look if I forgot something!

@silvbarb silvbarb requested a review from mbstadler February 8, 2024 18:56
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (74e4985) 100.00% compared to head (fccd367) 100.00%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          957       963    +6     
=========================================
+ Hits           957       963    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mbstadler mbstadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That all looks great, thanks you. I guess we can also adapt the quickstart.qmd to make use of this feature (and remove the not so elegant manual coordinate conversion).

@mbstadler
Copy link
Collaborator

I will adapt quickstart.qmd and push it to this same PR before merging.

@silvbarb
Copy link
Collaborator Author

silvbarb commented Feb 9, 2024

Sounds great! Thanks

@mbstadler mbstadler merged commit 9b01eae into main Feb 9, 2024
11 checks passed
@mbstadler mbstadler deleted the pyramid_level_coord-to-plot_well branch February 9, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants